[
https://issues.apache.org/jira/browse/BEAM-14014?focusedWorklogId=769805&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-769805
]
ASF GitHub Bot logged work on BEAM-14014:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/May/22 18:27
Start Date: 12/May/22 18:27
Worklog Time Spent: 10m
Work Description: kennknowles commented on code in PR #17244:
URL: https://github.com/apache/beam/pull/17244#discussion_r871689162
##########
sdks/python/apache_beam/internal/gcp/auth.py:
##########
@@ -59,7 +73,7 @@ def set_running_in_gce(worker_executing_project):
executing_project = worker_executing_project
-def get_service_credentials():
+def get_service_credentials(pipeline_options):
Review Comment:
yea if `None` is a valid type, then mention in the docstring what it means
Issue Time Tracking
-------------------
Worklog Id: (was: 769805)
Time Spent: 6.5h (was: 6h 20m)
> Support impersonation credentials in Dataflow runner.
> -----------------------------------------------------
>
> Key: BEAM-14014
> URL: https://issues.apache.org/jira/browse/BEAM-14014
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
> Reporter: Valentyn Tymofieiev
> Assignee: Ryan Thompson
> Priority: P2
> Time Spent: 6.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
