[
https://issues.apache.org/jira/browse/BEAM-14464?focusedWorklogId=769824&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-769824
]
ASF GitHub Bot logged work on BEAM-14464:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/May/22 19:02
Start Date: 12/May/22 19:02
Worklog Time Spent: 10m
Work Description: lukecwik commented on PR #17641:
URL: https://github.com/apache/beam/pull/17641#issuecomment-1125326811
I have been looking for someone to review
https://github.com/apache/beam/pull/17327, do you mind if we get that merged
first and then take on this change?
Issue Time Tracking
-------------------
Worklog Id: (was: 769824)
Time Spent: 0.5h (was: 20m)
> Optimize precombining table.
> ----------------------------
>
> Key: BEAM-14464
> URL: https://issues.apache.org/jira/browse/BEAM-14464
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Robert Bradshaw
> Priority: P2
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The current code constructs, hashes, and compares full WindowedValues for the
> grouping key, which ends up dominating the time spent in the combining table
> when using trivial combiners (like Sum.integers()). We only need compare the
> (structural value of the) key and windows, and can emit the windows in the
> global case.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
