[
https://issues.apache.org/jira/browse/BEAM-14464?focusedWorklogId=770377&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-770377
]
ASF GitHub Bot logged work on BEAM-14464:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/May/22 20:55
Start Date: 13/May/22 20:55
Worklog Time Spent: 10m
Work Description: robertwb commented on PR #17641:
URL: https://github.com/apache/beam/pull/17641#issuecomment-1126495490
Thanks, Yichi! As mentioned, I'm going to hold off merging this until that
other PR goes in.
Issue Time Tracking
-------------------
Worklog Id: (was: 770377)
Time Spent: 40m (was: 0.5h)
> Optimize precombining table.
> ----------------------------
>
> Key: BEAM-14464
> URL: https://issues.apache.org/jira/browse/BEAM-14464
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Robert Bradshaw
> Priority: P2
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The current code constructs, hashes, and compares full WindowedValues for the
> grouping key, which ends up dominating the time spent in the combining table
> when using trivial combiners (like Sum.integers()). We only need compare the
> (structural value of the) key and windows, and can emit the windows in the
> global case.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
