[ 
https://issues.apache.org/jira/browse/BEAM-14464?focusedWorklogId=777792&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-777792
 ]

ASF GitHub Bot logged work on BEAM-14464:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Jun/22 19:06
            Start Date: 02/Jun/22 19:06
    Worklog Time Spent: 10m 
      Work Description: aaltay commented on PR #17641:
URL: https://github.com/apache/beam/pull/17641#issuecomment-1145215327

   The other PR is merged. Could this be merged?




Issue Time Tracking
-------------------

    Worklog Id:     (was: 777792)
    Time Spent: 50m  (was: 40m)

> Optimize precombining table.
> ----------------------------
>
>                 Key: BEAM-14464
>                 URL: https://issues.apache.org/jira/browse/BEAM-14464
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Robert Bradshaw
>            Priority: P2
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> The current code constructs, hashes, and compares full WindowedValues for the 
> grouping key, which ends up dominating the time spent in the combining table 
> when using trivial combiners (like Sum.integers()). We only need compare the 
> (structural value of the) key and windows, and can emit the windows in the 
> global case.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to