[
https://issues.apache.org/jira/browse/BEAM-14170?focusedWorklogId=773133&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773133
]
ASF GitHub Bot logged work on BEAM-14170:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/May/22 18:04
Start Date: 21/May/22 18:04
Worklog Time Spent: 10m
Work Description: damccorm commented on code in PR #17471:
URL: https://github.com/apache/beam/pull/17471#discussion_r878744381
##########
runners/direct-java/build.gradle:
##########
@@ -178,6 +192,26 @@ task validatesRunner(type: Test) {
}
}
+tasks.register("validatesRunnerSickbay", Test) {
Review Comment:
This task gets duplicated a lot, with the only differences being the runner
and the classpath (and maybe the sickbayed test?). Instead of duplicating the
code, could you just programatically create them like this?
https://github.com/apache/beam/blob/e6c73b40f8376ec5088f69360108200ee5bd3813/examples/java/twitter/build.gradle#L81
##########
runners/direct-java/build.gradle:
##########
@@ -178,6 +192,26 @@ task validatesRunner(type: Test) {
}
}
+tasks.register("validatesRunnerSickbay", Test) {
+ group = "Verification"
+ description "Validates Direct runner (Sickbay Tests)"
+ systemProperty "beamTestPipelineOptions", JsonOutput.toJson([
+ "--runner=DirectRunner",
+ ])
+
+ classpath = configurations.needsRunner
+ testClassesDirs =
files(project(":sdks:java:core").sourceSets.test.output.classesDirs)
+
+ filter {
+ for (String test : sickbayTests) {
+ includeTestsMatching test
+ }
+
+ // https://issues.apache.org/jira/browse/BEAM-4191
+ includeTestsMatching
'org.apache.beam.runners.direct.WatermarkManagerTest.updateWatermarkWithDifferentWindowedValueInstances'
Review Comment:
Why do we just need this one on the direct runner and not the other ones?
Issue Time Tracking
-------------------
Worklog Id: (was: 773133)
Time Spent: 7h (was: 6h 50m)
> Create a test that runs sickbayed tests
> ---------------------------------------
>
> Key: BEAM-14170
> URL: https://issues.apache.org/jira/browse/BEAM-14170
> Project: Beam
> Issue Type: Test
> Components: testing
> Reporter: Kiley Sok
> Assignee: Andoni Guzman
> Priority: P2
> Time Spent: 7h
> Remaining Estimate: 0h
>
> When we sickbay tests we should continue to run them, at least in a new test
> suite that may hold flaky/sickbayed tests - often we just stop running them
> forever.
> Create a new test for Python and Java that runs the current sickbayed tests.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
