[
https://issues.apache.org/jira/browse/BEAM-14170?focusedWorklogId=775045&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-775045
]
ASF GitHub Bot logged work on BEAM-14170:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 26/May/22 13:02
Start Date: 26/May/22 13:02
Worklog Time Spent: 10m
Work Description: damccorm commented on code in PR #17471:
URL: https://github.com/apache/beam/pull/17471#discussion_r882643729
##########
runners/direct-java/build.gradle:
##########
@@ -178,6 +192,26 @@ task validatesRunner(type: Test) {
}
}
+tasks.register("validatesRunnerSickbay", Test) {
+ group = "Verification"
+ description "Validates Direct runner (Sickbay Tests)"
+ systemProperty "beamTestPipelineOptions", JsonOutput.toJson([
+ "--runner=DirectRunner",
+ ])
+
+ classpath = configurations.needsRunner
+ testClassesDirs =
files(project(":sdks:java:core").sourceSets.test.output.classesDirs)
+
+ filter {
+ for (String test : sickbayTests) {
+ includeTestsMatching test
+ }
+
+ // https://issues.apache.org/jira/browse/BEAM-4191
+ includeTestsMatching
'org.apache.beam.runners.direct.WatermarkManagerTest.updateWatermarkWithDifferentWindowedValueInstances'
Review Comment:
Whoops, accidentally deleted a comment, but I'm still unclear why this can't
be included in sickbayTests
##########
runners/direct-java/build.gradle:
##########
@@ -178,6 +192,26 @@ task validatesRunner(type: Test) {
}
}
+tasks.register("validatesRunnerSickbay", Test) {
Review Comment:
Yeah, actually taking another look I think you're right that this is more
trouble than its worth, especially since we also need the tests in
needsRunnerTests so there's not a super clean way to pull them out. Thanks for
pushing on this.
Issue Time Tracking
-------------------
Worklog Id: (was: 775045)
Time Spent: 7h 40m (was: 7.5h)
> Create a test that runs sickbayed tests
> ---------------------------------------
>
> Key: BEAM-14170
> URL: https://issues.apache.org/jira/browse/BEAM-14170
> Project: Beam
> Issue Type: Test
> Components: testing
> Reporter: Kiley Sok
> Assignee: Andoni Guzman
> Priority: P2
> Time Spent: 7h 40m
> Remaining Estimate: 0h
>
> When we sickbay tests we should continue to run them, at least in a new test
> suite that may hold flaky/sickbayed tests - often we just stop running them
> forever.
> Create a new test for Python and Java that runs the current sickbayed tests.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
