[ 
https://issues.apache.org/jira/browse/BEAM-14170?focusedWorklogId=774788&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-774788
 ]

ASF GitHub Bot logged work on BEAM-14170:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/May/22 19:41
            Start Date: 25/May/22 19:41
    Worklog Time Spent: 10m 
      Work Description: fernando-wizeline commented on code in PR #17471:
URL: https://github.com/apache/beam/pull/17471#discussion_r882047968


##########
runners/direct-java/build.gradle:
##########
@@ -178,6 +192,26 @@ task validatesRunner(type: Test) {
   }
 }
 
+tasks.register("validatesRunnerSickbay", Test) {

Review Comment:
   Hi Danny! I was creating the tasks programmatically, but since the tests for 
each runner are different, wouldn't it be better to leave the tasks like this 
instead of using conditional statements or creating a whole class hierarchy to 
dynamically access the tests for each runner?
   Sorry if this a silly question.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 774788)
    Time Spent: 7h 20m  (was: 7h 10m)

> Create a test that runs sickbayed tests
> ---------------------------------------
>
>                 Key: BEAM-14170
>                 URL: https://issues.apache.org/jira/browse/BEAM-14170
>             Project: Beam
>          Issue Type: Test
>          Components: testing
>            Reporter: Kiley Sok
>            Assignee: Andoni Guzman
>            Priority: P2
>          Time Spent: 7h 20m
>  Remaining Estimate: 0h
>
> When we sickbay tests we should continue to run them, at least in a new test 
> suite that may hold flaky/sickbayed tests - often we just stop running them 
> forever.
> Create a new test for Python and Java that runs the current sickbayed tests.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to