[
https://issues.apache.org/jira/browse/BEAM-7088?focusedWorklogId=229256&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-229256
]
ASF GitHub Bot logged work on BEAM-7088:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Apr/19 17:53
Start Date: 17/Apr/19 17:53
Worklog Time Spent: 10m
Work Description: pabloem commented on pull request #8316: [BEAM-7088]
Implement switch to using MonitoringInfo labels for Name and Namespace.
URL: https://github.com/apache/beam/pull/8316#discussion_r276346614
##########
File path:
runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/MetricsContainerImpl.java
##########
@@ -165,20 +164,26 @@ private MonitoringInfo
counterUpdateToMonitoringInfo(MetricUpdate<Long> metricUp
for (Entry<String, String> e :
monitoringInfoName.getLabels().entrySet()) {
builder.setLabel(e.getKey(), e.getValue());
}
- } else { // Note: (metricName instanceof MetricName) is always True.
- // Represents a user counter.
- builder.setUrnForUserMetric(
- metricUpdate.getKey().metricName().getNamespace(),
- metricUpdate.getKey().metricName().getName());
+ } else { // Represents a user counter.
// Drop if the stepname is not set. All user counters must be
// defined for a PTransform. They must be defined on a container bound
to a step.
if (this.stepName == null) {
return null;
Review comment:
Should we log that the counter is being dropped? So we can figure out what
user counters we're not appending the stepName for?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 229256)
Time Spent: 1.5h (was: 1h 20m)
> Utilize Name and Namespace labes instead of urn parts for MonitoringInfos
> -------------------------------------------------------------------------
>
> Key: BEAM-7088
> URL: https://issues.apache.org/jira/browse/BEAM-7088
> Project: Beam
> Issue Type: Improvement
> Components: runner-core
> Reporter: Mikhail Gryzykhin
> Assignee: Mikhail Gryzykhin
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Existing state:
> Counter Name and namespace are part of urn: "<urn_prefix>:<namespace>:<name>"
> Target state:
> urn: <urn_prefix>, labels \{"NAMESPACE":<namespace>, "NAME":<name>}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
