[
https://issues.apache.org/jira/browse/BEAM-7088?focusedWorklogId=229411&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-229411
]
ASF GitHub Bot logged work on BEAM-7088:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Apr/19 21:36
Start Date: 17/Apr/19 21:36
Worklog Time Spent: 10m
Work Description: ajamato commented on pull request #8316: [BEAM-7088]
Implement switch to using MonitoringInfo labels for Name and Namespace.
URL: https://github.com/apache/beam/pull/8316#discussion_r276372519
##########
File path: model/pipeline/src/main/proto/metrics.proto
##########
@@ -62,8 +62,13 @@ message MonitoringInfoSpecs {
// TODO(BEAM-6926): Add the PTRANSFORM name as a required label after
// upgrading the python SDK.
USER_COUNTER = 0 [(monitoring_info_spec) = {
- urn: "beam:metric:user:",
+ urn: "beam:metric:user",
Review comment:
It's not too late to change this since these are not persisted, it will get
picked up by all the code if we change this file. Adding a version number would
be most appropriate
"beam:metric:user_counter:v1"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 229411)
Time Spent: 1h 50m (was: 1h 40m)
> Utilize Name and Namespace labes instead of urn parts for MonitoringInfos
> -------------------------------------------------------------------------
>
> Key: BEAM-7088
> URL: https://issues.apache.org/jira/browse/BEAM-7088
> Project: Beam
> Issue Type: Improvement
> Components: runner-core
> Reporter: Mikhail Gryzykhin
> Assignee: Mikhail Gryzykhin
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Existing state:
> Counter Name and namespace are part of urn: "<urn_prefix>:<namespace>:<name>"
> Target state:
> urn: <urn_prefix>, labels \{"NAMESPACE":<namespace>, "NAME":<name>}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
