[
https://issues.apache.org/jira/browse/BEAM-7088?focusedWorklogId=229515&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-229515
]
ASF GitHub Bot logged work on BEAM-7088:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Apr/19 23:45
Start Date: 17/Apr/19 23:45
Worklog Time Spent: 10m
Work Description: Ardagan commented on pull request #8316: [BEAM-7088]
Implement switch to using MonitoringInfo labels for Name and Namespace.
URL: https://github.com/apache/beam/pull/8316#discussion_r276473682
##########
File path:
runners/core-java/src/test/java/org/apache/beam/runners/core/metrics/SpecMonitoringInfoValidatorTest.java
##########
@@ -50,9 +50,11 @@ public void
validateReturnsErrorOnInvalidMonitoringInfoType() {
public void validateReturnsNoErrorOnValidMonitoringInfo() {
MonitoringInfo testInput =
MonitoringInfo.newBuilder()
- .setUrn(Urns.USER_COUNTER_PREFIX + "someCounter")
+ .setUrn(Urns.USER_COUNTER)
+ .putLabels(MonitoringInfoConstants.Labels.NAME, "someCounter")
+ .putLabels(MonitoringInfoConstants.Labels.NAMESPACE, "")
Review comment:
Technically, that's correct. We match only sets of labels, whether value of
label is empty string or not -- that's not something specified in schema of
proto. This is a problem for any field in general as of now.
I'll keep code as-is and we can review this behavior in separate PR,
otherwise this one might grow too big.
Do you believe it is worth to create a jira ticket regarding this issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 229515)
Time Spent: 2.5h (was: 2h 20m)
> Utilize Name and Namespace labes instead of urn parts for MonitoringInfos
> -------------------------------------------------------------------------
>
> Key: BEAM-7088
> URL: https://issues.apache.org/jira/browse/BEAM-7088
> Project: Beam
> Issue Type: Improvement
> Components: runner-core
> Reporter: Mikhail Gryzykhin
> Assignee: Mikhail Gryzykhin
> Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Existing state:
> Counter Name and namespace are part of urn: "<urn_prefix>:<namespace>:<name>"
> Target state:
> urn: <urn_prefix>, labels \{"NAMESPACE":<namespace>, "NAME":<name>}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
