[
https://issues.apache.org/jira/browse/BEAM-7070?focusedWorklogId=230224&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-230224
]
ASF GitHub Bot logged work on BEAM-7070:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Apr/19 18:18
Start Date: 19/Apr/19 18:18
Worklog Time Spent: 10m
Work Description: amaliujia commented on pull request #8301: [BEAM-7070]
JOIN condition should accept field access
URL: https://github.com/apache/beam/pull/8301#discussion_r277054616
##########
File path:
sdks/java/testing/nexmark/src/test/java/org/apache/beam/sdk/nexmark/queries/QueryTest.java
##########
@@ -188,12 +188,14 @@ public void query5MatchesModelStreaming() {
@Test
@Category(NeedsRunner.class)
+ @Ignore("https://jira.apache.org/jira/browse/BEAM-7072";)
Review comment:
There was a bug (which is also fixed by this PR by throwing exception), if
there is a `JOIN ON a > b AND c < d`, BeamSQL executes it as `JOIN ON a = b AND
c = d`. From code you can see if there is a
[AND](https://github.com/apache/beam/blob/master/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamJoinRel.java#L499),
Beam code goes to extract JOIN column without checking what's
[condition](https://github.com/apache/beam/blob/master/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamJoinRel.java#L518).
And these ignored queries are using non equi-join with AND conjunction, and
BeamSQL has never supported non equi-join. So those queries worked by executing
all JOIN condition as `=`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 230224)
Time Spent: 4.5h (was: 4h 20m)
> JOIN condition should accept field access
> -----------------------------------------
>
> Key: BEAM-7070
> URL: https://issues.apache.org/jira/browse/BEAM-7070
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Rui Wang
> Assignee: Rui Wang
> Priority: Major
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
