[
https://issues.apache.org/jira/browse/BEAM-7070?focusedWorklogId=230225&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-230225
]
ASF GitHub Bot logged work on BEAM-7070:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Apr/19 18:21
Start Date: 19/Apr/19 18:21
Worklog Time Spent: 10m
Work Description: akedin commented on pull request #8301: [BEAM-7070]
JOIN condition should accept field access
URL: https://github.com/apache/beam/pull/8301#discussion_r277056624
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/utils/SerializableRexNode.java
##########
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.extensions.sql.impl.utils;
+
+import java.io.Serializable;
+import org.apache.calcite.rex.RexFieldAccess;
+import org.apache.calcite.rex.RexInputRef;
+import org.apache.calcite.rex.RexNode;
+
+/** SerializableRexNode. */
+public abstract class SerializableRexNode implements Serializable {
Review comment:
I am not sure, I think we will need to think about it a bit more. At this
point we're starting to replicate Calcite's relational model representation
just because we need to serialize some parts of it.
Also, at the moment this code is used only in `ExtractJoinFields` which
doesn't imply function calls. Maybe it's just naming.
Can you share the design for function calls? My concern is that we will need
to re-implement that part as well, even though now we have codegen that does
similar thing for us in calc rel. Can we re-use that part somehow? E.g. insert
a projection which will be backed up by codegen for field accesses and function
calls?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 230225)
Time Spent: 4h 40m (was: 4.5h)
> JOIN condition should accept field access
> -----------------------------------------
>
> Key: BEAM-7070
> URL: https://issues.apache.org/jira/browse/BEAM-7070
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Rui Wang
> Assignee: Rui Wang
> Priority: Major
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
