[
https://issues.apache.org/jira/browse/BEAM-7070?focusedWorklogId=230282&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-230282
]
ASF GitHub Bot logged work on BEAM-7070:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Apr/19 22:18
Start Date: 19/Apr/19 22:18
Worklog Time Spent: 10m
Work Description: kennknowles commented on pull request #8301:
[BEAM-7070] JOIN condition should accept field access
URL: https://github.com/apache/beam/pull/8301#discussion_r277103969
##########
File path:
sdks/java/testing/nexmark/src/test/java/org/apache/beam/sdk/nexmark/queries/QueryTest.java
##########
@@ -188,12 +188,14 @@ public void query5MatchesModelStreaming() {
@Test
@Category(NeedsRunner.class)
+ @Ignore("https://jira.apache.org/jira/browse/BEAM-7072";)
Review comment:
Yikes. One thought that we can do is if there is any equi-join then we can
do it first, and then do the rest as a filter operation after that. We could do
this in `toPTransform` or in rewrite rules. It might be hard in rewrite rules
because the transformation is not an "optimization" unless we leave it at
infinite cost until it is rewritten to what we can execute. I'm not sure how
easy that will be to express.
Are there tests that unimplementable joins are rejected?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 230282)
Time Spent: 5h 10m (was: 5h)
> JOIN condition should accept field access
> -----------------------------------------
>
> Key: BEAM-7070
> URL: https://issues.apache.org/jira/browse/BEAM-7070
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Rui Wang
> Assignee: Rui Wang
> Priority: Major
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
