[ 
https://issues.apache.org/jira/browse/BEAM-6627?focusedWorklogId=237827&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-237827
 ]

ASF GitHub Bot logged work on BEAM-6627:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 06/May/19 15:12
            Start Date: 06/May/19 15:12
    Worklog Time Spent: 10m 
      Work Description: lgajowy commented on pull request #8400: [BEAM-6627] 
Added byte and item counting metrics to integration tests
URL: https://github.com/apache/beam/pull/8400#discussion_r281227872
 
 

 ##########
 File path: 
sdks/java/io/file-based-io-tests/src/test/java/org/apache/beam/sdk/io/parquet/ParquetIOIT.java
 ##########
 @@ -137,6 +140,11 @@ public void writeThenReadAll() {
             .apply(
                 "Gather read start time",
                 ParDo.of(new TimeMonitor<>(PARQUET_NAMESPACE, "readStart")))
+            .apply(
+                "Collect byte count", ParDo.of(new 
ByteMonitor<>(PARQUET_NAMESPACE, "readBytes")))
+            .apply(
+                "Collect element count",
+                ParDo.of(new CountMonitor<>(PARQUET_NAMESPACE, 
"elementCount")))
 
 Review comment:
   This also applies to other names like this 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 237827)
    Time Spent: 12h 20m  (was: 12h 10m)

> Use Metrics API in IO performance tests
> ---------------------------------------
>
>                 Key: BEAM-6627
>                 URL: https://issues.apache.org/jira/browse/BEAM-6627
>             Project: Beam
>          Issue Type: Improvement
>          Components: testing
>            Reporter: Michal Walenia
>            Assignee: Michal Walenia
>            Priority: Minor
>          Time Spent: 12h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to