[
https://issues.apache.org/jira/browse/BEAM-6627?focusedWorklogId=239210&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-239210
]
ASF GitHub Bot logged work on BEAM-6627:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/May/19 13:48
Start Date: 08/May/19 13:48
Worklog Time Spent: 10m
Work Description: lgajowy commented on pull request #8400: [BEAM-6627]
Added byte and item counting metrics to integration tests
URL: https://github.com/apache/beam/pull/8400#discussion_r282044715
##########
File path:
sdks/java/io/file-based-io-tests/src/test/java/org/apache/beam/sdk/io/parquet/ParquetIOIT.java
##########
@@ -175,26 +185,41 @@ private void collectAndPublishMetrics(PipelineResult
result) {
Set<Function<MetricsReader, NamedTestResult>> metricSuppliers = new
HashSet<>();
metricSuppliers.add(
reader -> {
- long writeStart = reader.getStartTimeMetric("writeStart");
- long writeEnd = reader.getEndTimeMetric("writeEnd");
+ long writeStart =
reader.getStartTimeMetric(MetricNames.WRITE_START.getName());
+ long writeEnd =
reader.getEndTimeMetric(MetricNames.END_TIME.getName());
Review comment:
Why not `WRITE_END` here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 239210)
Time Spent: 13h (was: 12h 50m)
> Use Metrics API in IO performance tests
> ---------------------------------------
>
> Key: BEAM-6627
> URL: https://issues.apache.org/jira/browse/BEAM-6627
> Project: Beam
> Issue Type: Improvement
> Components: testing
> Reporter: Michal Walenia
> Assignee: Michal Walenia
> Priority: Minor
> Time Spent: 13h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
