[
https://issues.apache.org/jira/browse/BEAM-6627?focusedWorklogId=239209&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-239209
]
ASF GitHub Bot logged work on BEAM-6627:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/May/19 13:48
Start Date: 08/May/19 13:48
Worklog Time Spent: 10m
Work Description: lgajowy commented on pull request #8400: [BEAM-6627]
Added byte and item counting metrics to integration tests
URL: https://github.com/apache/beam/pull/8400#discussion_r282073803
##########
File path:
sdks/java/testing/test-utils/src/main/java/org/apache/beam/sdk/testutils/metrics/MetricNames.java
##########
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.testutils.metrics;
+
+public enum MetricNames {
Review comment:
Actually, after an offline discussion together with @mwalenia we decided to
remove this enum and replace it with concrete classes for each metric types.
Each class like this will contain:
- metric name
- supplier for the metric
- monitor for the metric
It turns out that all this (along with the monitor/supplier can be
encapsulated and then attached to the pipeline/metrics reading where needed.
This will also encapsulate the naming logic (so that there are no typos again).
For now we decided to remove this enum and provide the necessary changes in
other, dedicated PR. Issue for that:
https://issues.apache.org/jira/browse/BEAM-7245
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 239209)
Time Spent: 13h (was: 12h 50m)
> Use Metrics API in IO performance tests
> ---------------------------------------
>
> Key: BEAM-6627
> URL: https://issues.apache.org/jira/browse/BEAM-6627
> Project: Beam
> Issue Type: Improvement
> Components: testing
> Reporter: Michal Walenia
> Assignee: Michal Walenia
> Priority: Minor
> Time Spent: 13h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
