[
https://issues.apache.org/jira/browse/BEAM-7271?focusedWorklogId=241010&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-241010
]
ASF GitHub Bot logged work on BEAM-7271:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/May/19 10:26
Start Date: 13/May/19 10:26
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #8557: [BEAM-7271] adding
UTF8 String coder to Java SDK ModelCoder
URL: https://github.com/apache/beam/pull/8557#discussion_r283279115
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/ExecutableStageDoFnOperator.java
##########
@@ -773,8 +773,7 @@ public void setForWindow(InputT input, BoundedWindow
window) {
// make sure this fires after any window.maxTimestamp() timers
Instant gcTime = LateDataUtils.garbageCollectionTime(window,
windowingStrategy).plus(1);
// needs to match the encoding in prepareStateBackend for state request
handler
- final ByteBuffer key =
- FlinkKeyUtils.encodeKey(((KV) input).getKey(), keyCoder,
Coder.Context.NESTED);
+ final ByteBuffer key = FlinkKeyUtils.encodeKey(((KV) input).getKey(),
keyCoder);
Review comment:
```suggestion
final ByteBuffer key =
FlinkKeyUtils.encodeKey(((KV) input).getKey(), keyCoder,
Coder.Context.NESTED);
```
This needs to be reverted because it otherwise breaks the trigger for state
cleanup.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 241010)
Time Spent: 1h 20m (was: 1h 10m)
> Adding StringUtf8Coder to ModelCoder in JavaSDK [REOPENED]
> ----------------------------------------------------------
>
> Key: BEAM-7271
> URL: https://issues.apache.org/jira/browse/BEAM-7271
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Reopend for the reverted previous commit.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
