[
https://issues.apache.org/jira/browse/BEAM-7271?focusedWorklogId=241011&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-241011
]
ASF GitHub Bot logged work on BEAM-7271:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/May/19 10:26
Start Date: 13/May/19 10:26
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #8557: [BEAM-7271] adding
UTF8 String coder to Java SDK ModelCoder
URL: https://github.com/apache/beam/pull/8557#discussion_r283279283
##########
File path:
runners/flink/src/test/java/org/apache/beam/runners/flink/translation/wrappers/streaming/ExecutableStageDoFnOperatorTest.java
##########
@@ -432,7 +432,7 @@ public void
testEnsureStateCleanupWithKeyedInputCleanupTimer() {
cleanupTimer.setForWindow(KV.of("key", "string"), window);
Mockito.verify(stateBackendLock).lock();
- ByteBuffer key = FlinkKeyUtils.encodeKey("key", keyCoder,
Coder.Context.NESTED);
+ ByteBuffer key = FlinkKeyUtils.encodeKey("key", keyCoder);
Review comment:
```suggestion
ByteBuffer key = FlinkKeyUtils.encodeKey("key", keyCoder,
Coder.Context.NESTED);
```
Needs to be reverted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 241011)
Time Spent: 1.5h (was: 1h 20m)
> Adding StringUtf8Coder to ModelCoder in JavaSDK [REOPENED]
> ----------------------------------------------------------
>
> Key: BEAM-7271
> URL: https://issues.apache.org/jira/browse/BEAM-7271
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Reopend for the reverted previous commit.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
