[
https://issues.apache.org/jira/browse/BEAM-7271?focusedWorklogId=241214&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-241214
]
ASF GitHub Bot logged work on BEAM-7271:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/May/19 18:11
Start Date: 13/May/19 18:11
Worklog Time Spent: 10m
Work Description: ihji commented on pull request #8557: [BEAM-7271]
adding UTF8 String coder to Java SDK ModelCoder
URL: https://github.com/apache/beam/pull/8557#discussion_r283470426
##########
File path:
runners/flink/src/test/java/org/apache/beam/runners/flink/translation/wrappers/streaming/ExecutableStageDoFnOperatorTest.java
##########
@@ -432,7 +432,7 @@ public void
testEnsureStateCleanupWithKeyedInputCleanupTimer() {
cleanupTimer.setForWindow(KV.of("key", "string"), window);
Mockito.verify(stateBackendLock).lock();
- ByteBuffer key = FlinkKeyUtils.encodeKey("key", keyCoder,
Coder.Context.NESTED);
+ ByteBuffer key = FlinkKeyUtils.encodeKey("key", keyCoder);
Review comment:
Thanks @mxm for the review. Reverting this will cause `Key Group xx does not
belong to the local range.` exception. I think somewhere in the source there's
a mismatch between encoding methods. Do we have a test for state cleanup?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 241214)
Time Spent: 1h 50m (was: 1h 40m)
> Adding StringUtf8Coder to ModelCoder in JavaSDK [REOPENED]
> ----------------------------------------------------------
>
> Key: BEAM-7271
> URL: https://issues.apache.org/jira/browse/BEAM-7271
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Reopend for the reverted previous commit.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
