[
https://issues.apache.org/jira/browse/BEAM-7274?focusedWorklogId=249859&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-249859
]
ASF GitHub Bot logged work on BEAM-7274:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/May/19 06:28
Start Date: 29/May/19 06:28
Worklog Time Spent: 10m
Work Description: reuvenlax commented on issue #8690: [BEAM-7274]
Implement the Protobuf schema provider
URL: https://github.com/apache/beam/pull/8690#issuecomment-496802876
I'm still reviewing this. A few high-level thoughts off the bat:
* I'm not thrilled about creating a ProtoRow object, as I've so far
attempted to prevent Row from becoming an "open" class that can by extended by
users. I'd be happier if we could do this the way we did Avro classes, by
generating a set of getters/setters (it would probably be more efficient as
well)
* There are various places where logical types would be preferable - e.g.
all the places where multiple proto types map to a single Beam schema type. As
written today the conversion is lossy - if you selected just that field, there
would be no way to get the original proto type back; LogicalTypes provide a
simple way of fixing this, though we could defer that to a future PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 249859)
Time Spent: 0.5h (was: 20m)
> Protobuf Beam Schema support
> ----------------------------
>
> Key: BEAM-7274
> URL: https://issues.apache.org/jira/browse/BEAM-7274
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Alex Van Boxel
> Assignee: Alex Van Boxel
> Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Add support for the new Beam Schema to the Protobuf extension.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
