[
https://issues.apache.org/jira/browse/BEAM-7274?focusedWorklogId=251769&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-251769
]
ASF GitHub Bot logged work on BEAM-7274:
----------------------------------------
Author: ASF GitHub Bot
Created on: 31/May/19 12:46
Start Date: 31/May/19 12:46
Worklog Time Spent: 10m
Work Description: alexvanboxel commented on issue #8690: [BEAM-7274]
Implement the Protobuf schema provider
URL: https://github.com/apache/beam/pull/8690#issuecomment-497695744
I got it to work with the RowWithGetters but now without modifying it. See
https://github.com/alexvanboxel/beam/commit/1da5715c74d1f3c5de66ae4ebcddcc148bfa7915
I keep on handling the List/Map/Row with the Getters as I need more context
then the other implementations. Personally I find this better and more flexible
then doing it in the `RowWithGetters` as you have more ways to give context
(example: proto map is a repeatable message).
I looked for reference to the `GenericRecord` in Avro, but was disappointed
that the `GenericRecord` gets materialised in a `RowWithStorage`. I'm quite
sure with having the getters that handle collection this could be changed to
`RowWithGetters`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 251769)
Time Spent: 1h (was: 50m)
> Protobuf Beam Schema support
> ----------------------------
>
> Key: BEAM-7274
> URL: https://issues.apache.org/jira/browse/BEAM-7274
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Alex Van Boxel
> Assignee: Alex Van Boxel
> Priority: Minor
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Add support for the new Beam Schema to the Protobuf extension.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
