[
https://issues.apache.org/jira/browse/BEAM-7274?focusedWorklogId=249897&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-249897
]
ASF GitHub Bot logged work on BEAM-7274:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/May/19 07:09
Start Date: 29/May/19 07:09
Worklog Time Spent: 10m
Work Description: alexvanboxel commented on issue #8690: [BEAM-7274]
Implement the Protobuf schema provider
URL: https://github.com/apache/beam/pull/8690#issuecomment-496813519
@reuvenlax I'll wait for your complete review, but keep in mind that I
wanted a uniform way for handling concrete typed classes and DynamicType
(DynamicType do require access via the FieldDescriptor). I had trouble getting
it in the same way as the AvroUtils, but maybe this is due to my unfamiliarity
with it. (I'm open to try to convert it, as most of the effort is spend in the
tests anyway. The for internal use only note in the Java doc didn't seem
encouraging to use though.
On LogicalTypes: Are you talking about Fixed32/Fixed64/UInt32/UInt64? I
simply took the Scalar mapping described here:
https://developers.google.com/protocol-buffers/docs/proto#scalar
If you are talking about Timestamp... well I like to have this configurable.
Having it default to DATETIME will be a helper for making it available in Beam
SQL or in output IO's like BigQuery.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 249897)
Time Spent: 40m (was: 0.5h)
> Protobuf Beam Schema support
> ----------------------------
>
> Key: BEAM-7274
> URL: https://issues.apache.org/jira/browse/BEAM-7274
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Alex Van Boxel
> Assignee: Alex Van Boxel
> Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Add support for the new Beam Schema to the Protobuf extension.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
