[
https://issues.apache.org/jira/browse/BEAM-7428?focusedWorklogId=249959&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-249959
]
ASF GitHub Bot logged work on BEAM-7428:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/May/19 08:33
Start Date: 29/May/19 08:33
Worklog Time Spent: 10m
Work Description: iemejia commented on issue #8691: [BEAM-7428] Output
the timestamp on elements in ReadAllViaFileBasedSource
URL: https://github.com/apache/beam/pull/8691#issuecomment-496840121
I agree that the failures are weird, but maybe they are happening because we
were hiding the case by not adding the timestamp when outputting. In any case
it seems we should be consistent in both classes where we do the similar
action: `JavaReadViaImpulse` and `ReadAllViaFileBasedSource`. Do we take into
account the timestamp or do we ignore it but probably is not good to mix both
behaviors (that's why I did all the other refactorings, but they are not
mandatory for the core aspect of this iissue).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 249959)
Time Spent: 1h 50m (was: 1h 40m)
> ReadAllViaFileBasedSource does not output the timestamps of the read elements
> -----------------------------------------------------------------------------
>
> Key: BEAM-7428
> URL: https://issues.apache.org/jira/browse/BEAM-7428
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Ismaël Mejía
> Assignee: Ismaël Mejía
> Priority: Minor
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> This differs from the implementation of JavaReadViaImpulse that tackles a
> similar problem but does output the timestamps correctly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
