[
https://issues.apache.org/jira/browse/BEAM-7428?focusedWorklogId=256402&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-256402
]
ASF GitHub Bot logged work on BEAM-7428:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jun/19 10:29
Start Date: 08/Jun/19 10:29
Worklog Time Spent: 10m
Work Description: iemejia commented on issue #8741: [BEAM-7428] Output
the timestamp on elements in ReadAllViaFileBasedSource
URL: https://github.com/apache/beam/pull/8741#issuecomment-500113618
Does this mean that to have a correct behavior we should make
[`BoundedReader.getCurrentTimestamp`](https://github.com/apache/beam/blob/c85f0f51634e65fe332e8bbe18fbf0689eb44d0f/sdks/java/core/src/main/java/org/apache/beam/sdk/io/BoundedSource.java#L393-L397)
`final` to avoid that it gets overridden and someone outputs anything
different of -INF as a timestamp? [Of course this is a breaking change but at
least in theory] or we should just ignore timestamps of `BoundedReader` to make
the change have less impact?].
What made me discover this issue was to see the different behaviour of the
[`JavaReadViaImpulse` wrapping of the Source
API](https://github.com/apache/beam/blob/c85f0f51634e65fe332e8bbe18fbf0689eb44d0f/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/JavaReadViaImpulse.java#L139),
maybe we should not output with timestamps there to be consistent everywhere?
Pinging @jkff in case he is around and have something to say too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 256402)
Time Spent: 3h 10m (was: 3h)
> ReadAllViaFileBasedSource does not output the timestamps of the read elements
> -----------------------------------------------------------------------------
>
> Key: BEAM-7428
> URL: https://issues.apache.org/jira/browse/BEAM-7428
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Ismaël Mejía
> Assignee: Ismaël Mejía
> Priority: Minor
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> This differs from the implementation of JavaReadViaImpulse that tackles a
> similar problem but does output the timestamps correctly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
