[
https://issues.apache.org/jira/browse/BEAM-7416?focusedWorklogId=254403&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-254403
]
ASF GitHub Bot logged work on BEAM-7416:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Jun/19 14:32
Start Date: 05/Jun/19 14:32
Worklog Time Spent: 10m
Work Description: kamilwu commented on pull request #8731: [BEAM-7416]
MetricsReader in Python should save only supported metrics
URL: https://github.com/apache/beam/pull/8731#discussion_r290769822
##########
File path:
sdks/python/apache_beam/testing/load_tests/load_test_metrics_utils.py
##########
@@ -47,8 +47,10 @@
SchemaField = None
NotFound = None
-RUNTIME_METRIC = 'runtime'
-COUNTER_LABEL = 'total_bytes_count'
+METRICS = {
Review comment:
I'm a bit concerned about this nested dictionary. It's fine if there will be
more metrics types (aside from counters and distributions) in the future. But
if not, it would be easier if you split this into two dictionaries.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 254403)
Time Spent: 40m (was: 0.5h)
> MetricsReader in Python reports all available metrics.
> ------------------------------------------------------
>
> Key: BEAM-7416
> URL: https://issues.apache.org/jira/browse/BEAM-7416
> Project: Beam
> Issue Type: Bug
> Components: testing
> Reporter: Michal Walenia
> Assignee: Kasia Kucharczyk
> Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> MetricsMonitor in Python reports all metrics regardless of metrics acutally
> applied to the pipeline by user.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
