[
https://issues.apache.org/jira/browse/BEAM-7416?focusedWorklogId=255819&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-255819
]
ASF GitHub Bot logged work on BEAM-7416:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jun/19 11:18
Start Date: 07/Jun/19 11:18
Worklog Time Spent: 10m
Work Description: robertwb commented on issue #8731: [BEAM-7416]
MetricsReader in Python should save only supported metrics
URL: https://github.com/apache/beam/pull/8731#issuecomment-499848502
Is collecting additional metrics a problem? It might be helpful to have
them around.
On Fri, Jun 7, 2019 at 1:10 PM Kasia Kucharczyk <[email protected]>
wrote:
> *@kkucharc* commented on this pull request.
> ------------------------------
>
> In sdks/python/apache_beam/testing/load_tests/load_test_metrics_utils.py
> <https://github.com/apache/beam/pull/8731#discussion_r291548506>:
>
> > @@ -47,8 +47,10 @@
> SchemaField = None
> NotFound = None
>
> -RUNTIME_METRIC = 'runtime'
> -COUNTER_LABEL = 'total_bytes_count'
> +METRICS = {
>
> Well, there is possibility we will have gauges as well.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
>
<https://github.com/apache/beam/pull/8731?email_source=notifications&email_token=AADWVAOD32FEJGCUYOSIEQTPZI63JA5CNFSM4HR3SHKKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB24X2ZA#discussion_r291548506>,
> or mute the thread
>
<https://github.com/notifications/unsubscribe-auth/AADWVAITPERJY7CJTR4TOJTPZI63JANCNFSM4HR3SHKA>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 255819)
Time Spent: 1h 10m (was: 1h)
> MetricsReader in Python reports all available metrics.
> ------------------------------------------------------
>
> Key: BEAM-7416
> URL: https://issues.apache.org/jira/browse/BEAM-7416
> Project: Beam
> Issue Type: Bug
> Components: testing
> Reporter: Michal Walenia
> Assignee: Kasia Kucharczyk
> Priority: Minor
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> MetricsMonitor in Python reports all metrics regardless of metrics acutally
> applied to the pipeline by user.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
