[
https://issues.apache.org/jira/browse/BEAM-7416?focusedWorklogId=255937&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-255937
]
ASF GitHub Bot logged work on BEAM-7416:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jun/19 14:20
Start Date: 07/Jun/19 14:20
Worklog Time Spent: 10m
Work Description: kkucharc commented on issue #8731: [BEAM-7416]
MetricsReader in Python should save only supported metrics
URL: https://github.com/apache/beam/pull/8731#issuecomment-499903607
That sounds reasonable - it may be useful in the future. It shouldn't make
problems for filtering. Those are usually 5-15 additional rows (each row has
test id, metric type and value) which doesn't come from metrics specified by
us, I believe it's not big expense for now.
I can wait for author of issue opinion @mwalenia or if you agree I will
close this PR and issue.
Michał needs one bugfix solved in this PR (the additional metrics are
influencing our runtime metric) but I will solve it in another dedicated PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 255937)
Time Spent: 1h 40m (was: 1.5h)
> MetricsReader in Python reports all available metrics.
> ------------------------------------------------------
>
> Key: BEAM-7416
> URL: https://issues.apache.org/jira/browse/BEAM-7416
> Project: Beam
> Issue Type: Bug
> Components: testing
> Reporter: Michal Walenia
> Assignee: Kasia Kucharczyk
> Priority: Minor
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> MetricsMonitor in Python reports all metrics regardless of metrics acutally
> applied to the pipeline by user.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
