[
https://issues.apache.org/jira/browse/BEAM-4046?focusedWorklogId=266908&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-266908
]
ASF GitHub Bot logged work on BEAM-4046:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Jun/19 18:13
Start Date: 25/Jun/19 18:13
Worklog Time Spent: 10m
Work Description: markflyhigh commented on issue #8919: [BEAM-4046,
BEAM-7527] Fix benchmark with correct Gradle project
URL: https://github.com/apache/beam/pull/8919#issuecomment-505560414
Realized that the changes on PerfkitBenchmarker
(https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/1934) only pass
Python tests but not Java. My quick fix
(https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/1936) is out
waiting for review.
In order to run Jenkins job based on Perfkit fix, I pointed
PerfkitBenchmarker git repo to my fix branch in this PR and both Java
ParquetIOPerformance and Python WordCountIT passed:
- https://builds.apache.org/job/beam_PerformanceTests_ParquetIOIT/1616/
- https://builds.apache.org/job/beam_PerformanceTests_WordCountIT_Py27/164/
Given that review on Perfkit may take a day or two, Java benchmarks will be
blocked during this period, I would prefer to point PerfkitBenchmarker repo to
my fix branch first and I'll switch back to master once it's merged. Would love
to create a jira tracking this if make sense to you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 266908)
Time Spent: 38h 50m (was: 38h 40m)
> Decouple gradle project names and maven artifact ids
> ----------------------------------------------------
>
> Key: BEAM-4046
> URL: https://issues.apache.org/jira/browse/BEAM-4046
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
> Reporter: Kenneth Knowles
> Assignee: Michael Luckey
> Priority: Major
> Time Spent: 38h 50m
> Remaining Estimate: 0h
>
> In our first draft, we had gradle projects like {{":beam-sdks-java-core"}}.
> It is clumsy and requires a hacky settings.gradle that is not idiomatic.
> In our second draft, we changed them to names that work well with Gradle,
> like {{":sdks:java:core"}}. This caused Maven artifact IDs to be wonky.
> In our third draft, we regressed to the first draft to get the Maven artifact
> ids right.
> These should be able to be decoupled. It seems there are many StackOverflow
> questions on the subject.
> Since it is unidiomatic and a poor user experience, if it does turn out to be
> mandatory then it needs to be documented inline everywhere - the
> settings.gradle should say why it is so bizarre, and each build.gradle should
> indicate what its project id is.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
