[
https://issues.apache.org/jira/browse/BEAM-4046?focusedWorklogId=267465&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-267465
]
ASF GitHub Bot logged work on BEAM-4046:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jun/19 10:35
Start Date: 26/Jun/19 10:35
Worklog Time Spent: 10m
Work Description: lgajowy commented on issue #8919: [BEAM-4046,
BEAM-7527] Fix benchmark with correct Gradle project
URL: https://github.com/apache/beam/pull/8919#issuecomment-505819481
That's ok. Thank you for doing this. I don't think changing the fork is
necessary - let's wait until the Perfkit change gets merged. We can intervene
after some longer period of time in case the change is not merged but from what
I see it shouldn't be the case (it was approved).
This situation (once again) shows that this is not good that Beam tests are
dependent on Perfkit's master. Currently, any breaking change can turn lots of
our tests red. Do you by any chance know if it is possible to keep all
benchmark beam code from Perfkit (`beam_benchmark_helper.py`,
`beam_integration_benchmark.py`) in beam repository and inject it to perfkit
every time we use it? I think that would be the best solution in our case. We
could do whatever we want in beam_benchmark code without the need to submit PRs
everytime we want to change anything.
Alternatively, maybe we could drop Perfkit (at least for IOITs this is
doable right now). ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 267465)
Time Spent: 39h 10m (was: 39h)
> Decouple gradle project names and maven artifact ids
> ----------------------------------------------------
>
> Key: BEAM-4046
> URL: https://issues.apache.org/jira/browse/BEAM-4046
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
> Reporter: Kenneth Knowles
> Assignee: Michael Luckey
> Priority: Major
> Time Spent: 39h 10m
> Remaining Estimate: 0h
>
> In our first draft, we had gradle projects like {{":beam-sdks-java-core"}}.
> It is clumsy and requires a hacky settings.gradle that is not idiomatic.
> In our second draft, we changed them to names that work well with Gradle,
> like {{":sdks:java:core"}}. This caused Maven artifact IDs to be wonky.
> In our third draft, we regressed to the first draft to get the Maven artifact
> ids right.
> These should be able to be decoupled. It seems there are many StackOverflow
> questions on the subject.
> Since it is unidiomatic and a poor user experience, if it does turn out to be
> mandatory then it needs to be documented inline everywhere - the
> settings.gradle should say why it is so bizarre, and each build.gradle should
> indicate what its project id is.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
