[
https://issues.apache.org/jira/browse/BEAM-4046?focusedWorklogId=268113&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-268113
]
ASF GitHub Bot logged work on BEAM-4046:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jun/19 00:14
Start Date: 27/Jun/19 00:14
Worklog Time Spent: 10m
Work Description: markflyhigh commented on issue #8919: [BEAM-4046,
BEAM-7527] Fix benchmark with correct Gradle project
URL: https://github.com/apache/beam/pull/8919#issuecomment-505970620
SGTM. Let's wait for
https://github.com/GoogleCloudPlatform/PerfKitBenchmarker/pull/1936 merge.
As for dependent on Perfkit master, I would prefer remove Perfkit at all
since there are few other issues that limit our benchmarks. For example:
1. Black box testing which hard to collect pipeline related metrics.
2. Measurement of runtime is inaccurate.
3. Can't run in Python3 (depends on py2 only library like `functools32`)
4. `beam_integration_benchmark.py` inherit the complexity of Perfkit
framework and require some knowledge to maintain.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 268113)
Time Spent: 39h 50m (was: 39h 40m)
> Decouple gradle project names and maven artifact ids
> ----------------------------------------------------
>
> Key: BEAM-4046
> URL: https://issues.apache.org/jira/browse/BEAM-4046
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
> Reporter: Kenneth Knowles
> Assignee: Michael Luckey
> Priority: Major
> Time Spent: 39h 50m
> Remaining Estimate: 0h
>
> In our first draft, we had gradle projects like {{":beam-sdks-java-core"}}.
> It is clumsy and requires a hacky settings.gradle that is not idiomatic.
> In our second draft, we changed them to names that work well with Gradle,
> like {{":sdks:java:core"}}. This caused Maven artifact IDs to be wonky.
> In our third draft, we regressed to the first draft to get the Maven artifact
> ids right.
> These should be able to be decoupled. It seems there are many StackOverflow
> questions on the subject.
> Since it is unidiomatic and a poor user experience, if it does turn out to be
> mandatory then it needs to be documented inline everywhere - the
> settings.gradle should say why it is so bizarre, and each build.gradle should
> indicate what its project id is.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
