[
https://issues.apache.org/jira/browse/BEAM-8162?focusedWorklogId=307998&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-307998
]
ASF GitHub Bot logged work on BEAM-8162:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Sep/19 16:22
Start Date: 06/Sep/19 16:22
Worklog Time Spent: 10m
Work Description: mxm commented on issue #9464: [BEAM-8162] Encode keys
as NESTED for flink keyselector
URL: https://github.com/apache/beam/pull/9464#issuecomment-528920697
To comment on your summary, only approach `#2` and `#3` are possible because
we cannot change the SDKs internal encoding. The encoding should be transparent
to the Runner and independent of the key encoding a Runner chooses. The state
request handler which caused the issues happens to leak the internal encoding
of the SDK.
I agree that it would be convenient to just use NESTED context. I'm not
against it. However, I think it is also valid to keep the existing behavior, as
the state requests is the only interface that exposes the raw key. In any case,
it makes sense to think about this, test this, and ask the people who are most
familiar with the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 307998)
Time Spent: 0.5h (was: 20m)
> NPE error when add flink 1.9 runner
> -----------------------------------
>
> Key: BEAM-8162
> URL: https://issues.apache.org/jira/browse/BEAM-8162
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: sunjincheng
> Assignee: sunjincheng
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When add flink 1.9 runner in https://github.com/apache/beam/pull/9296, we
> find an NPE error when run the `PortableTimersExecutionTest`.
> the detail can be found here:
> https://github.com/apache/beam/pull/9296#issuecomment-525262607
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
