[
https://issues.apache.org/jira/browse/BEAM-7013?focusedWorklogId=309254&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-309254
]
ASF GitHub Bot logged work on BEAM-7013:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Sep/19 21:19
Start Date: 09/Sep/19 21:19
Worklog Time Spent: 10m
Work Description: robinyqiu commented on pull request #9519: [BEAM-7013]
Use a 0-length byte array to represent empty sketch in HllCount
URL: https://github.com/apache/beam/pull/9519#discussion_r322342971
##########
File path:
sdks/java/extensions/zetasketch/src/test/java/org/apache/beam/sdk/extensions/zetasketch/HllCountTest.java
##########
@@ -86,13 +88,6 @@
LONGS_SKETCH = hll.serializeToByteArray();
}
- private static final byte[] LONGS_EMPTY_SKETCH;
-
- static {
- HyperLogLogPlusPlus<Long> hll = new
HyperLogLogPlusPlus.Builder().buildForLongs();
- LONGS_EMPTY_SKETCH = hll.serializeToByteArray();
- }
-
Review comment:
The current implementation can handles this case. I agree that keeping tests
for this case is valuable, so I have added it back and added a couple more. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 309254)
Time Spent: 30h 20m (was: 30h 10m)
> A new count distinct transform based on BigQuery compatible HyperLogLog++
> implementation
> ----------------------------------------------------------------------------------------
>
> Key: BEAM-7013
> URL: https://issues.apache.org/jira/browse/BEAM-7013
> Project: Beam
> Issue Type: New Feature
> Components: extensions-java-sketching, sdk-java-core
> Reporter: Yueyang Qiu
> Assignee: Yueyang Qiu
> Priority: Major
> Fix For: 2.16.0
>
> Time Spent: 30h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
