[
https://issues.apache.org/jira/browse/BEAM-7013?focusedWorklogId=309034&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-309034
]
ASF GitHub Bot logged work on BEAM-7013:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Sep/19 16:22
Start Date: 09/Sep/19 16:22
Worklog Time Spent: 10m
Work Description: zfraa commented on pull request #9519: [BEAM-7013] Use
a 0-length byte array to represent empty sketch in HllCount
URL: https://github.com/apache/beam/pull/9519#discussion_r322267553
##########
File path:
sdks/java/extensions/zetasketch/src/main/java/org/apache/beam/sdk/extensions/zetasketch/HllCountMergePartialFn.java
##########
@@ -54,10 +54,15 @@ private HllCountMergePartialFn() {}
return null;
}
+ @Nullable
@Override
public HyperLogLogPlusPlus<HllT> addInput(
@Nullable HyperLogLogPlusPlus<HllT> accumulator, byte[] input) {
- if (accumulator == null) {
+ if (input == null) {
+ throw new NullPointerException("Null is not a valid sketch.");
+ } else if (input.length == 0) {
+ return accumulator;
+ } else if (accumulator == null) {
Review comment:
Did you consider to change the "empty accumulator" representation from null
to byte[0] as well? Pros/Cons?
(It might be conceptually easier to just have one representation for empty
sketches -- the same internally and externally; but I don't see any large
benefits to doing the change, so...)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 309034)
> A new count distinct transform based on BigQuery compatible HyperLogLog++
> implementation
> ----------------------------------------------------------------------------------------
>
> Key: BEAM-7013
> URL: https://issues.apache.org/jira/browse/BEAM-7013
> Project: Beam
> Issue Type: New Feature
> Components: extensions-java-sketching, sdk-java-core
> Reporter: Yueyang Qiu
> Assignee: Yueyang Qiu
> Priority: Major
> Fix For: 2.16.0
>
> Time Spent: 30h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
