[
https://issues.apache.org/jira/browse/BEAM-7013?focusedWorklogId=309033&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-309033
]
ASF GitHub Bot logged work on BEAM-7013:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Sep/19 16:22
Start Date: 09/Sep/19 16:22
Worklog Time Spent: 10m
Work Description: zfraa commented on pull request #9519: [BEAM-7013] Use
a 0-length byte array to represent empty sketch in HllCount
URL: https://github.com/apache/beam/pull/9519#discussion_r322257094
##########
File path:
sdks/java/extensions/zetasketch/src/main/java/org/apache/beam/sdk/extensions/zetasketch/HllCountInitFn.java
##########
@@ -57,6 +57,11 @@ void setPrecision(int precision) {
this.precision = precision;
}
+ @Override
+ public byte[] defaultValue() {
+ return new byte[0];
Review comment:
Maybe add an implementation comment, sth like:
"An empty aggregation is represented by an empty byte[], since we cannot
create sketches without knowing their type. byte[] is space-efficient, but
safer than null. As opposed to returning an empty PCollection, it allows us to
return '0' when extracting from the sketch."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 309033)
> A new count distinct transform based on BigQuery compatible HyperLogLog++
> implementation
> ----------------------------------------------------------------------------------------
>
> Key: BEAM-7013
> URL: https://issues.apache.org/jira/browse/BEAM-7013
> Project: Beam
> Issue Type: New Feature
> Components: extensions-java-sketching, sdk-java-core
> Reporter: Yueyang Qiu
> Assignee: Yueyang Qiu
> Priority: Major
> Fix For: 2.16.0
>
> Time Spent: 30h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
