[
https://issues.apache.org/jira/browse/BEAM-8165?focusedWorklogId=309936&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-309936
]
ASF GitHub Bot logged work on BEAM-8165:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Sep/19 16:33
Start Date: 10/Sep/19 16:33
Worklog Time Spent: 10m
Work Description: aaltay commented on pull request #9487:
[BEAM-8165]Change default docker images name
URL: https://github.com/apache/beam/pull/9487#discussion_r322845563
##########
File path: sdks/python/container/py2/build.gradle
##########
@@ -51,8 +52,13 @@ task copyLauncherDependencies(type: Copy) {
}
}
+def sdk_version = '2.16.0'
Review comment:
This is probably not a good idea. The reason is:
- This needs to match the
https://github.com/apache/beam/blob/master/sdks/python/apache_beam/version.py -
So it needs to be 2.16.0.dev here
- Release process needs to be updated to change these versions along with
other versions. Release process automatically changes the version in the
release branch to remove the ".dev" part and changes master branch to the next
version.
- If we have to do this, at least is it possible to put this in a single
gradle file?
- Another idea, we can execute or parse
https://github.com/apache/beam/blob/master/sdks/python/apache_beam/version.py
and extract version from here. That should be possible with gradle.
@yifanzou could you help with this?
/cc @markflyhigh as the release manager.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 309936)
Time Spent: 40m (was: 0.5h)
> Change image name and add images to release process
> ---------------------------------------------------
>
> Key: BEAM-8165
> URL: https://issues.apache.org/jira/browse/BEAM-8165
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go, sdk-java-harness, sdk-py-harness
> Reporter: Hannah Jiang
> Assignee: Hannah Jiang
> Priority: Major
> Fix For: 2.16.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> change name to apachebeam/\{lang}{ver}_sdk
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
