[
https://issues.apache.org/jira/browse/BEAM-8341?focusedWorklogId=330039&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-330039
]
ASF GitHub Bot logged work on BEAM-8341:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Oct/19 17:52
Start Date: 17/Oct/19 17:52
Worklog Time Spent: 10m
Work Description: xinyuiscool commented on pull request #9777:
[BEAM-8341]: basic bundling support for portable runner
URL: https://github.com/apache/beam/pull/9777#discussion_r336139447
##########
File path:
runners/samza/src/main/java/org/apache/beam/runners/samza/runtime/DoFnOp.java
##########
@@ -280,9 +365,26 @@ public void processWatermark(Instant watermark,
OpEmitter<OutT> emitter) {
}
}
+ @Override
+ public void processWatermark(Instant watermark, OpEmitter<OutT> emitter) {
+ if (!isBundleStarted.get()) {
+ doProcessWatermark(watermark, emitter);
+ } else {
+ // if there is a bundle in progress, hold back the watermark until end
of the bundle
+ this.bundleWatermarkHold = watermark;
+ if (watermark.isEqual(BoundedWindow.TIMESTAMP_MAX_VALUE)) {
+ // for batch mode, the max watermark should force the bundle to close
+ finishBundle(emitter);
+ }
+ }
+ }
+
@Override
public void processSideInput(
String id, WindowedValue<? extends Iterable<?>> elements,
OpEmitter<OutT> emitter) {
+ checkState(
Review comment:
Move this check to the translator so it can throw before running.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 330039)
Time Spent: 50m (was: 40m)
> basic bundling support for samza portable runner
> ------------------------------------------------
>
> Key: BEAM-8341
> URL: https://issues.apache.org/jira/browse/BEAM-8341
> Project: Beam
> Issue Type: Task
> Components: runner-samza
> Reporter: Hai Lu
> Assignee: Hai Lu
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> bundling support for samza portable runner
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
