[
https://issues.apache.org/jira/browse/BEAM-8341?focusedWorklogId=330036&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-330036
]
ASF GitHub Bot logged work on BEAM-8341:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Oct/19 17:52
Start Date: 17/Oct/19 17:52
Worklog Time Spent: 10m
Work Description: xinyuiscool commented on pull request #9777:
[BEAM-8341]: basic bundling support for portable runner
URL: https://github.com/apache/beam/pull/9777#discussion_r336139214
##########
File path:
runners/samza/src/main/java/org/apache/beam/runners/samza/runtime/DoFnOp.java
##########
@@ -237,9 +292,39 @@ private String getTimerStateId(DoFnSignature signature) {
return builder.toString();
}
+ private void attemptStartBundle() {
+ if (isBundleStarted.compareAndSet(false, true)) {
Review comment:
thread safety is still bit awkward here as if another thread invokes
attemptStartBundle() in a different thread after the the line of finishBundle,
the count and time can still be set in a non-consistent manner. I guess we
don't allow multiple threads in the same task right now. But it can cause
problems. Could you add a check in the translator to make sure we don't have
task.max.concurrency bigger than 1 if bundling is enabled?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 330036)
Time Spent: 0.5h (was: 20m)
> basic bundling support for samza portable runner
> ------------------------------------------------
>
> Key: BEAM-8341
> URL: https://issues.apache.org/jira/browse/BEAM-8341
> Project: Beam
> Issue Type: Task
> Components: runner-samza
> Reporter: Hai Lu
> Assignee: Hai Lu
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> bundling support for samza portable runner
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
