[
https://issues.apache.org/jira/browse/BEAM-8341?focusedWorklogId=331534&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-331534
]
ASF GitHub Bot logged work on BEAM-8341:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Oct/19 17:42
Start Date: 21/Oct/19 17:42
Worklog Time Spent: 10m
Work Description: lhaiesp commented on pull request #9777: [BEAM-8341]:
basic bundling support for portable runner
URL: https://github.com/apache/beam/pull/9777#discussion_r337150103
##########
File path:
runners/samza/src/main/java/org/apache/beam/runners/samza/runtime/DoFnOp.java
##########
@@ -237,9 +292,39 @@ private String getTimerStateId(DoFnSignature signature) {
return builder.toString();
}
+ private void attemptStartBundle() {
+ if (isBundleStarted.compareAndSet(false, true)) {
+ currentBundleElementCount.set(0L);
+ bundleStartTime.set(System.currentTimeMillis());
+ pushbackFnRunner.startBundle();
Review comment:
There are two models. 1) the current model is to regularly check in the
background to see whether max bundling time is hit; this is only roughly
accurate but more efficient 2) schedule a timer for EVERY bundle start. This is
more accurate but we may end up scheduling too many timer when the QPS is too
high. Let's discuss this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 331534)
Time Spent: 1h (was: 50m)
> basic bundling support for samza portable runner
> ------------------------------------------------
>
> Key: BEAM-8341
> URL: https://issues.apache.org/jira/browse/BEAM-8341
> Project: Beam
> Issue Type: Task
> Components: runner-samza
> Reporter: Hai Lu
> Assignee: Hai Lu
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> bundling support for samza portable runner
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
