[
https://issues.apache.org/jira/browse/BEAM-8398?focusedWorklogId=336273&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-336273
]
ASF GitHub Bot logged work on BEAM-8398:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Oct/19 16:40
Start Date: 30/Oct/19 16:40
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9792: [BEAM-8398]
Upgrade Dataflow Java Client API
URL: https://github.com/apache/beam/pull/9792#discussion_r340731086
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubJsonClient.java
##########
@@ -169,7 +169,7 @@ public int publish(TopicPath topic, List<OutgoingMessage>
outgoingMessages) thro
@Nullable Map<String, String> attributes = pubsubMessage.getAttributes();
// Payload.
- byte[] elementBytes = pubsubMessage.decodeData();
+ byte[] elementBytes = pubsubMessage.getData() == null ? null :
pubsubMessage.decodeData();
Review comment:
It looks like the Base64 library version went through several changes from
[1.27](https://github.com/googleapis/google-http-java-client/blob/v1.27.0/google-http-client/src/main/java/com/google/api/client/util/Base64.java)
->
[1.28](https://github.com/googleapis/google-http-java-client/blob/v1.28.0/google-http-client/src/main/java/com/google/api/client/util/Base64.java),
mainly swapping from commons codec to Guava's version of base64 encoding.
Maybe Guava made a backwards incompatible change or the override from Guava
26.0-android back to 20.0 that we are now forcing because of the upgrade is
causing the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 336273)
Time Spent: 2h (was: 1h 50m)
> Upgrade Dataflow Java Client API
> --------------------------------
>
> Key: BEAM-8398
> URL: https://issues.apache.org/jira/browse/BEAM-8398
> Project: Beam
> Issue Type: Task
> Components: runner-dataflow
> Reporter: Kyle Weaver
> Assignee: Kyle Weaver
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
