[
https://issues.apache.org/jira/browse/BEAM-8398?focusedWorklogId=336303&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-336303
]
ASF GitHub Bot logged work on BEAM-8398:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Oct/19 17:07
Start Date: 30/Oct/19 17:07
Worklog Time Spent: 10m
Work Description: ibzib commented on pull request #9792: [BEAM-8398]
Upgrade Dataflow Java Client API
URL: https://github.com/apache/beam/pull/9792#discussion_r340746507
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubJsonClient.java
##########
@@ -169,7 +169,7 @@ public int publish(TopicPath topic, List<OutgoingMessage>
outgoingMessages) thro
@Nullable Map<String, String> attributes = pubsubMessage.getAttributes();
// Payload.
- byte[] elementBytes = pubsubMessage.decodeData();
+ byte[] elementBytes = pubsubMessage.getData() == null ? null :
pubsubMessage.decodeData();
Review comment:
This was a problem with the HTTP client. (`PubsubMessage::decodeData` and
`Base64` Javadocs clearly state that they will return null if the input is
null, but this behavior relied on Guava's `BaseEncoding` implementation, which
AFAICT never made such a promise.) Apparently this was fixed in version 1.30.0
of the HTTP client:
https://github.com/googleapis/google-http-java-client/pull/644
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 336303)
Time Spent: 2.5h (was: 2h 20m)
> Upgrade Dataflow Java Client API
> --------------------------------
>
> Key: BEAM-8398
> URL: https://issues.apache.org/jira/browse/BEAM-8398
> Project: Beam
> Issue Type: Task
> Components: runner-dataflow
> Reporter: Kyle Weaver
> Assignee: Kyle Weaver
> Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
