[
https://issues.apache.org/jira/browse/BEAM-8398?focusedWorklogId=336285&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-336285
]
ASF GitHub Bot logged work on BEAM-8398:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Oct/19 16:52
Start Date: 30/Oct/19 16:52
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9792: [BEAM-8398]
Upgrade Dataflow Java Client API
URL: https://github.com/apache/beam/pull/9792#discussion_r340736852
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubJsonClient.java
##########
@@ -169,7 +169,7 @@ public int publish(TopicPath topic, List<OutgoingMessage>
outgoingMessages) thro
@Nullable Map<String, String> attributes = pubsubMessage.getAttributes();
// Payload.
- byte[] elementBytes = pubsubMessage.decodeData();
+ byte[] elementBytes = pubsubMessage.getData() == null ? null :
pubsubMessage.decodeData();
Review comment:
It looks like Guavas 20 and Guava 26 Base64 didn't allow nulls so checking
getData should be fine replacement for prior logic.
It may also be that the test is wrong and should have really called
encodeData with an empty byte array to get the no data case for testing but it
is unclear from the pubsub documentation what the contents of the field maybe
so this is the safer route.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 336285)
Time Spent: 2h 20m (was: 2h 10m)
> Upgrade Dataflow Java Client API
> --------------------------------
>
> Key: BEAM-8398
> URL: https://issues.apache.org/jira/browse/BEAM-8398
> Project: Beam
> Issue Type: Task
> Components: runner-dataflow
> Reporter: Kyle Weaver
> Assignee: Kyle Weaver
> Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
