[
https://issues.apache.org/jira/browse/BEAM-7274?focusedWorklogId=351548&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-351548
]
ASF GitHub Bot logged work on BEAM-7274:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Nov/19 18:52
Start Date: 30/Nov/19 18:52
Worklog Time Spent: 10m
Work Description: alexvanboxel commented on pull request #10247:
[BEAM-7274] In preparation for protocol-buffer schemas, add OneOf and
Enumeration logical types
URL: https://github.com/apache/beam/pull/10247#discussion_r352298646
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/Schema.java
##########
@@ -181,6 +183,14 @@ public Builder addBooleanField(String name) {
return this;
}
+ public Builder addEnumerationField(String name, EnumerationType
enumerationType) {
Review comment:
Does it make sense to add these methods as first class add'ers to Schema?
This feels like breaking consistency... as they are logical types.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 351548)
Time Spent: 11.5h (was: 11h 20m)
> Protobuf Beam Schema support
> ----------------------------
>
> Key: BEAM-7274
> URL: https://issues.apache.org/jira/browse/BEAM-7274
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Alex Van Boxel
> Assignee: Alex Van Boxel
> Priority: Minor
> Time Spent: 11.5h
> Remaining Estimate: 0h
>
> Add support for the new Beam Schema to the Protobuf extension.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
