[
https://issues.apache.org/jira/browse/BEAM-7274?focusedWorklogId=351559&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-351559
]
ASF GitHub Bot logged work on BEAM-7274:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Nov/19 19:51
Start Date: 30/Nov/19 19:51
Worklog Time Spent: 10m
Work Description: reuvenlax commented on pull request #10247: [BEAM-7274]
In preparation for protocol-buffer schemas, add OneOf and Enumeration logical
types
URL: https://github.com/apache/beam/pull/10247#discussion_r352301313
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/Schema.java
##########
@@ -181,6 +183,14 @@ public Builder addBooleanField(String name) {
return this;
}
+ public Builder addEnumerationField(String name, EnumerationType
enumerationType) {
Review comment:
Originally I left them out. But then decided that these are fairly "basic"
logical types (e.g. they exist in proto, avro, etc.) so it was worth adding
this method as syntactic sugar. I don't feel very strongly about it either way
though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 351559)
Time Spent: 11h 40m (was: 11.5h)
> Protobuf Beam Schema support
> ----------------------------
>
> Key: BEAM-7274
> URL: https://issues.apache.org/jira/browse/BEAM-7274
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Alex Van Boxel
> Assignee: Alex Van Boxel
> Priority: Minor
> Time Spent: 11h 40m
> Remaining Estimate: 0h
>
> Add support for the new Beam Schema to the Protobuf extension.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
