[ 
https://issues.apache.org/jira/browse/BEAM-7274?focusedWorklogId=351560&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-351560
 ]

ASF GitHub Bot logged work on BEAM-7274:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 30/Nov/19 19:51
            Start Date: 30/Nov/19 19:51
    Worklog Time Spent: 10m 
      Work Description: reuvenlax commented on pull request #10247: [BEAM-7274] 
In preparation for protocol-buffer schemas, add OneOf and Enumeration logical 
types
URL: https://github.com/apache/beam/pull/10247#discussion_r352301326
 
 

 ##########
 File path: sdks/java/core/src/main/java/org/apache/beam/sdk/values/Row.java
 ##########
 @@ -208,6 +210,26 @@ public Boolean getBoolean(String fieldName) {
     return getMap(getSchema().indexOf(fieldName));
   }
 
+  /** Helper method to get an enum field value. */
+  public EnumerationValue getEnumValue(String fieldValue) {
 
 Review comment:
   See above (also keep in mind that we want to make DATETIME a logical type as 
well). However I don't feel strongly one way or the other about this.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 351560)
    Time Spent: 11h 50m  (was: 11h 40m)

> Protobuf Beam Schema support
> ----------------------------
>
>                 Key: BEAM-7274
>                 URL: https://issues.apache.org/jira/browse/BEAM-7274
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Alex Van Boxel
>            Assignee: Alex Van Boxel
>            Priority: Minor
>          Time Spent: 11h 50m
>  Remaining Estimate: 0h
>
> Add support for the new Beam Schema to the Protobuf extension.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to