[
https://issues.apache.org/jira/browse/BEAM-8623?focusedWorklogId=352318&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-352318
]
ASF GitHub Bot logged work on BEAM-8623:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Dec/19 00:00
Start Date: 03/Dec/19 00:00
Worklog Time Spent: 10m
Work Description: angoenka commented on pull request #10075: [BEAM-8623]
Add status_endpoint field to provision api ProvisionInfo
URL: https://github.com/apache/beam/pull/10075#discussion_r352920881
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/DataflowWorkerHarnessHelper.java
##########
@@ -113,6 +114,18 @@ public static void
configureLogging(DataflowWorkerHarnessOptions pipelineOptions
return
parseApiServiceDescriptorFromText(System.getenv().get(CONTROL_API_SERVICE_DESCRIPTOR));
}
+ @Nullable
+ public static Endpoints.ApiServiceDescriptor getStatusDescriptor()
+ throws TextFormat.ParseException {
+ try {
+ return
parseApiServiceDescriptorFromText(System.getenv().get(STATUS_API_SERVICE_DESCRIPTOR));
+ } catch (NullPointerException e) {
Review comment:
Shall we do explicit null check instead of catching null pointer?
If null pointer is thrown from within a method then it will be better to
limit the try block only to that method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 352318)
Time Spent: 1h (was: 50m)
> Add additional message field to Provision API response for passing status
> endpoint
> ----------------------------------------------------------------------------------
>
> Key: BEAM-8623
> URL: https://issues.apache.org/jira/browse/BEAM-8623
> Project: Beam
> Issue Type: Sub-task
> Components: beam-model
> Reporter: Yichi Zhang
> Assignee: Yichi Zhang
> Priority: Minor
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
