[ 
https://issues.apache.org/jira/browse/BEAM-8623?focusedWorklogId=352364&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-352364
 ]

ASF GitHub Bot logged work on BEAM-8623:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Dec/19 01:02
            Start Date: 03/Dec/19 01:02
    Worklog Time Spent: 10m 
      Work Description: y1chi commented on pull request #10075: [BEAM-8623] Add 
status_endpoint field to provision api ProvisionInfo
URL: https://github.com/apache/beam/pull/10075#discussion_r352939229
 
 

 ##########
 File path: sdks/go/pkg/beam/core/runtime/harness/init/init.go
 ##########
 @@ -42,6 +42,7 @@ var (
        id              = flag.String("id", "", "Local identifier (required in 
worker mode).")
        loggingEndpoint = flag.String("logging_endpoint", "", "Local logging 
gRPC endpoint (required in worker mode).")
        controlEndpoint = flag.String("control_endpoint", "", "Local control 
gRPC endpoint (required in worker mode).")
+       statusEndpoint  = flag.String("status_endpoint", "", "Local status gRPC 
endpoint (optional in worker mode).")
 
 Review comment:
   I can remove this. will there be any downsides for adding them in all 
together except that the variable is unused(semiPersistDir here is unused as 
well). 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 352364)
    Time Spent: 1h 20m  (was: 1h 10m)

> Add additional message field to Provision API response for passing status 
> endpoint
> ----------------------------------------------------------------------------------
>
>                 Key: BEAM-8623
>                 URL: https://issues.apache.org/jira/browse/BEAM-8623
>             Project: Beam
>          Issue Type: Sub-task
>          Components: beam-model
>            Reporter: Yichi Zhang
>            Assignee: Yichi Zhang
>            Priority: Minor
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to