[
https://issues.apache.org/jira/browse/BEAM-8623?focusedWorklogId=352362&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-352362
]
ASF GitHub Bot logged work on BEAM-8623:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Dec/19 01:00
Start Date: 03/Dec/19 01:00
Worklog Time Spent: 10m
Work Description: y1chi commented on pull request #10075: [BEAM-8623] Add
status_endpoint field to provision api ProvisionInfo
URL: https://github.com/apache/beam/pull/10075#discussion_r352938620
##########
File path: sdks/go/container/boot.go
##########
@@ -122,6 +122,10 @@ func main() {
"--semi_persist_dir=" + *semiPersistDir,
"--options=" + options,
}
+ if info.GetStatusEndpoint() != nil {
+ args = append(args,
"--status_endpoint="+info.GetStatusEndpoint().GetUrl())
Review comment:
I think this only affects go sdk. Java and python uses env var to pass the
url as I changed in their corresponding boot.go.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 352362)
Time Spent: 1h 10m (was: 1h)
> Add additional message field to Provision API response for passing status
> endpoint
> ----------------------------------------------------------------------------------
>
> Key: BEAM-8623
> URL: https://issues.apache.org/jira/browse/BEAM-8623
> Project: Beam
> Issue Type: Sub-task
> Components: beam-model
> Reporter: Yichi Zhang
> Assignee: Yichi Zhang
> Priority: Minor
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
