[ 
https://issues.apache.org/jira/browse/BEAM-7951?focusedWorklogId=354588&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-354588
 ]

ASF GitHub Bot logged work on BEAM-7951:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 05/Dec/19 19:05
            Start Date: 05/Dec/19 19:05
    Worklog Time Spent: 10m 
      Work Description: lukecwik commented on pull request #9979: [BEAM-7951] 
Allow runner to configure customization WindowedValue coder.
URL: https://github.com/apache/beam/pull/9979#discussion_r354469091
 
 

 ##########
 File path: model/pipeline/src/main/proto/beam_runner_api.proto
 ##########
 @@ -672,6 +672,13 @@ message StandardCoders {
     // Components: The element coder and the window coder, in that order
     WINDOWED_VALUE = 8 [(beam_urn) = "beam:coder:windowed_value:v1"];
 
+    // A windowed value coder with parameterized timestamp, windows and 
PaneInfo.
 
 Review comment:
   I think we have to be explicit that the payload is an encoded windowed value 
using the beam:coder:windowed_value:v1 coder parameterized by 
beam:coder:bytes:v1 elements coder and the window coder that this 
param_windowed_value uses.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 354588)
    Time Spent: 4h  (was: 3h 50m)

> Allow runner to configure customization WindowedValue coder such as 
> ValueOnlyWindowedValueCoder
> -----------------------------------------------------------------------------------------------
>
>                 Key: BEAM-7951
>                 URL: https://issues.apache.org/jira/browse/BEAM-7951
>             Project: Beam
>          Issue Type: Sub-task
>          Components: java-fn-execution
>            Reporter: sunjincheng
>            Assignee: sunjincheng
>            Priority: Major
>          Time Spent: 4h
>  Remaining Estimate: 0h
>
> The coder of WindowedValue cannot be configured and it’s always 
> FullWindowedValueCoder. We don't need to serialize the timestamp, window and 
> pane properties in Flink and so it will be better to make the coder 
> configurable (i.e. allowing to use ValueOnlyWindowedValueCoder)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to