[
https://issues.apache.org/jira/browse/BEAM-7951?focusedWorklogId=354606&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-354606
]
ASF GitHub Bot logged work on BEAM-7951:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Dec/19 19:05
Start Date: 05/Dec/19 19:05
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9979: [BEAM-7951]
Allow runner to configure customization WindowedValue coder.
URL: https://github.com/apache/beam/pull/9979#discussion_r354489572
##########
File path: sdks/python/apache_beam/coders/coder_impl.py
##########
@@ -1088,6 +1088,54 @@ def get_estimated_size_and_observables(self, value,
nested=False):
return estimated_size, observables
+class ParamWindowedValueCoderImpl(WindowedValueCoderImpl):
+ """For internal use only; no backwards-compatibility guarantees.
+
+ A coder for windowed values with constant timestamp, windows and
+ pane info. The coder drops timestamp and windows for encoding,
+ and uses the constant timestamp, and windows for decoding."""
Review comment:
```suggestion
and uses the constant timestamp, and windows during decoding."""
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 354606)
> Allow runner to configure customization WindowedValue coder such as
> ValueOnlyWindowedValueCoder
> -----------------------------------------------------------------------------------------------
>
> Key: BEAM-7951
> URL: https://issues.apache.org/jira/browse/BEAM-7951
> Project: Beam
> Issue Type: Sub-task
> Components: java-fn-execution
> Reporter: sunjincheng
> Assignee: sunjincheng
> Priority: Major
> Time Spent: 5h 20m
> Remaining Estimate: 0h
>
> The coder of WindowedValue cannot be configured and it’s always
> FullWindowedValueCoder. We don't need to serialize the timestamp, window and
> pane properties in Flink and so it will be better to make the coder
> configurable (i.e. allowing to use ValueOnlyWindowedValueCoder)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
