[
https://issues.apache.org/jira/browse/BEAM-7951?focusedWorklogId=354591&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-354591
]
ASF GitHub Bot logged work on BEAM-7951:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Dec/19 19:05
Start Date: 05/Dec/19 19:05
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9979: [BEAM-7951]
Allow runner to configure customization WindowedValue coder.
URL: https://github.com/apache/beam/pull/9979#discussion_r354475918
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/util/WindowedValue.java
##########
@@ -500,9 +500,9 @@ private void ensureWindowsAreASet() {
return FullWindowedValueCoder.of(valueCoder, windowCoder);
}
- /** Returns the {@code ValueOnlyCoder} from the given valueCoder. */
- public static <T> ValueOnlyWindowedValueCoder<T> getValueOnlyCoder(Coder<T>
valueCoder) {
- return ValueOnlyWindowedValueCoder.of(valueCoder);
+ /** Returns the {@code ParamWindowedValueCoder} from the given valueCoder. */
+ public static <T> ParamWindowedValueCoder<T> getValueOnlyCoder(Coder<T>
valueCoder) {
Review comment:
This will break pipeline update for Dataflow since we will be changing the
type of coder being returned and used within existing users pipeline.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 354591)
Time Spent: 4h 10m (was: 4h)
> Allow runner to configure customization WindowedValue coder such as
> ValueOnlyWindowedValueCoder
> -----------------------------------------------------------------------------------------------
>
> Key: BEAM-7951
> URL: https://issues.apache.org/jira/browse/BEAM-7951
> Project: Beam
> Issue Type: Sub-task
> Components: java-fn-execution
> Reporter: sunjincheng
> Assignee: sunjincheng
> Priority: Major
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> The coder of WindowedValue cannot be configured and it’s always
> FullWindowedValueCoder. We don't need to serialize the timestamp, window and
> pane properties in Flink and so it will be better to make the coder
> configurable (i.e. allowing to use ValueOnlyWindowedValueCoder)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
